2023/06/24: Difference between revisions
Jump to navigation
Jump to search
No edit summary |
No edit summary |
||
Line 1: | Line 1: | ||
{{page/date}} | {{page/date}} | ||
==Notes== | ==Notes== | ||
* [https://github.com/wikimedia/mediawiki/blob/master/includes/specialpage/SpecialPageFactory.php#L1449 SpecialPageFactory.php line 1449 (was 1318)] calls $this->getPage( $name ); | |||
* [https://github.com/wikimedia/mediawiki/blob/master/includes/specialpage/SpecialPageFactory.php#L1411 SpecialPageFactory.php line 1411 (was 1283)] calls <syntaxhighlight lang=php inline>$this->objectFactory->createObject($rec,['allowClassName' => true,'allowCallable' => true]);</syntaxhighlight> | * [https://github.com/wikimedia/mediawiki/blob/master/includes/specialpage/SpecialPageFactory.php#L1411 SpecialPageFactory.php line 1411 (was 1283)] calls <syntaxhighlight lang=php inline>$this->objectFactory->createObject($rec,['allowClassName' => true,'allowCallable' => true]);</syntaxhighlight> | ||
** This seems to be where the problem comes in: | |||
*** $rec is supposed to be an array or a string that matches certain criteria. | |||
*** <syntaxhighlight lang=php inline>$rec = $specialPageList[$realName];</syntaxhighlight> | |||
*** <syntaxhighlight lang=php inline>[ $realName ] = $this->resolveAlias( $name );</syntaxhighlight> // extracts $realName from the first item returned (the "real name" is always first, I guess... seems a bit sloppy) | |||
* [https://github.com/wikimedia/mediawiki-libs-ObjectFactory/blob/3558d6630cefa60491e468965752651bc5bf3d3e/src/ObjectFactory.php#L152 ObjectFactory.php line 152] calls static::getObjectFromSpec( $spec, $options ); | * [https://github.com/wikimedia/mediawiki-libs-ObjectFactory/blob/3558d6630cefa60491e468965752651bc5bf3d3e/src/ObjectFactory.php#L152 ObjectFactory.php line 152] calls static::getObjectFromSpec( $spec, $options ); | ||
* [https://github.com/wikimedia/mediawiki-libs-ObjectFactory/blob/3558d6630cefa60491e468965752651bc5bf3d3e/src/ObjectFactory.php#L177 ObjectFactory.php line 177] calls static::validateSpec( $spec, $options ); | * [https://github.com/wikimedia/mediawiki-libs-ObjectFactory/blob/3558d6630cefa60491e468965752651bc5bf3d3e/src/ObjectFactory.php#L177 ObjectFactory.php line 177] calls static::validateSpec( $spec, $options ); | ||
* [https://github.com/wikimedia/mediawiki-libs-ObjectFactory/blob/3558d6630cefa60491e468965752651bc5bf3d3e/src/ObjectFactory.php#L302 ObjectFactory.php line 302] is in validateSpec( $spec, array $options ), throws exception | * [https://github.com/wikimedia/mediawiki-libs-ObjectFactory/blob/3558d6630cefa60491e468965752651bc5bf3d3e/src/ObjectFactory.php#L302 ObjectFactory.php line 302] is in validateSpec( $spec, array $options ), throws exception |
Revision as of 14:36, 24 June 2023
Saturday, June 24, 2023 (#175)
|
Notes
|