Ferreteria/sql/user session: Difference between revisions

From Woozle Writes Code
Jump to navigation Jump to search
(→‎Security: a bit of clarity on how the security works)
(ID_User)
Line 10: Line 10:
*** user can't reload the receipt page
*** user can't reload the receipt page
*** we can't detect if the user has already sent in an order, so we can't ask if they want to add to it or modify it
*** we can't detect if the user has already sent in an order, so we can't ask if they want to add to it or modify it
** '''2013-09-26''' added '''ID_User''' -- this is how we know if the user is logged in.
* '''Relations''':
* '''Relations''':
** Each {{vbzcart|table|shop_client}} has one or more {{vbzcart|table|shop_session}}s
** Each {{vbzcart|table|shop_client}} has one or more {{vbzcart|table|shop_session}}s
Line 26: Line 27:


==SQL==
==SQL==
<section begin=sql /><mysql>DROP TABLE IF EXISTS `shop_session`;
<mysql>DROP TABLE IF EXISTS `shop_session`;
CREATE TABLE `shop_session` (
CREATE TABLE `shop_session` (
   `ID`          INT    NOT NULL AUTO_INCREMENT,
   `ID`          INT    NOT NULL AUTO_INCREMENT,
Line 32: Line 33:
   `ID_Cart`    INT DEFAULT NULL COMMENT "shop_cart.ID currently active for this session",
   `ID_Cart`    INT DEFAULT NULL COMMENT "shop_cart.ID currently active for this session",
   `ID_Order`    INT DEFAULT NULL COMMENT "order ID to which cart was converted (if any)",
   `ID_Order`    INT DEFAULT NULL COMMENT "order ID to which cart was converted (if any)",
  `ID_User`    INT DEFAULT NULL COMMENT "ID of logged-in user, if any",
   `Token`      VARCHAR(31)      COMMENT "session identifier passed as cookie = random string",
   `Token`      VARCHAR(31)      COMMENT "session identifier passed as cookie = random string",
   `WhenCreated` DATETIME        COMMENT "when session was created",
   `WhenCreated` DATETIME        COMMENT "when session was created",
Line 39: Line 41:
   UNIQUE KEY(`Token`)
   UNIQUE KEY(`Token`)
  ) ENGINE = MYISAM;</mysql>
  ) ENGINE = MYISAM;</mysql>
<section end=sql />

Revision as of 13:12, 26 September 2013

About

  • History:
    • 2009-06-18 design started - first draft, not sure concept is right
    • 2009-07-10 each session ties to a cart, not vice-versa; Token is now a random string
    • 2011-02-07 fixing bug where user gets the same cart again after placing an order:
      • ID_Cart is now cleared when cart is converted to an order, so that same cart won't get reloaded
      • ID_Order field so we can still pull up the order when ID_Cart is cleared
      • Remember, this is the active cart. After cart is converted to an order, it is no longer active.
    • 2011-03-27 decided that clearing ID_Cart is a bad idea, because:
      • user can't reload the receipt page
      • we can't detect if the user has already sent in an order, so we can't ask if they want to add to it or modify it
    • 2013-09-26 added ID_User -- this is how we know if the user is logged in.
  • Relations:
  • Usage:
    • For now, we will be treating each Template:Vbzcart as having its own session which never expires. Having a separate class for the session, though, lets us decouple these things later on if we want to.
    • There should eventually be an "empty cart" button; if the user has not logged in, then that button should start a new session rather than clearing the cart for the current session.
  • Fields:
    • WhenClosed: if not NULL, then this session should not be reused (might be a different user returning to their cart, or might be the same user -- if no login, we have no way of telling, so take safest choice). If this session is accessed after the time of WhenExpires, code should manually set WhenClosed to NOW().

Security

I briefly toyed with the idea of only allowing the session to be set via http query within the secure area once and thereafter requiring it to come from a cookie, but anyone familiar with wget could spoof a cookie pretty easily, so this didn't seem worth the effort.

The real security comes from requiring that client's fingerprint (browser + IP address) "match" those in the session record for the session token (which the client must also give) before authorizing renewal of a session for that client. The session token is essentially a "shared secret" generated by the server.

SQL

<mysql>DROP TABLE IF EXISTS `shop_session`; CREATE TABLE `shop_session` (

 `ID`          INT     NOT NULL AUTO_INCREMENT,
 `ID_Client`   INT     NOT NULL COMMENT "shop_client.ID",
 `ID_Cart`     INT DEFAULT NULL COMMENT "shop_cart.ID currently active for this session",
 `ID_Order`    INT DEFAULT NULL COMMENT "order ID to which cart was converted (if any)",
 `ID_User`     INT DEFAULT NULL COMMENT "ID of logged-in user, if any",
 `Token`       VARCHAR(31)      COMMENT "session identifier passed as cookie = random string",
 `WhenCreated` DATETIME         COMMENT "when session was created",
 `WhenExpires` DATETIME         COMMENT "when session was due to expire",
 `WhenClosed`  DATETIME         COMMENT "when the session was closed",
 PRIMARY KEY(`ID`),
 UNIQUE KEY(`Token`)
) ENGINE = MYISAM;</mysql>